[tor-bugs] #34050 [Circumvention/Snowflake]: Restore check for nil writePipe in WebRTCPeer.Close

Tue Apr 28 17:37:13 UTC 2020

#34050: Restore check for nil writePipe in WebRTCPeer.Close
-----------------------------------------+----------------------
     Reporter:  dcf                      |      Owner:  dcf
         Type:  defect                   |     Status:  assigned
     Priority:  Medium                   |  Milestone:
    Component:  Circumvention/Snowflake  |    Version:
     Severity:  Normal                   |   Keywords:
Actual Points:                           |  Parent ID:
       Points:                           |   Reviewer:
      Sponsor:                           |
-----------------------------------------+----------------------
 I removed this check in [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a
 047d3214bfb46de07e5d9f223e4fb1ba24584c8a] because `NewWebRTCPeer` always
 initializes `writePipe`, and it is never reset to `nil`. However tests
 used `&WebRTCPeer{}` which bypasses `NewWebRTCPeer` and leaves `writePipe`
 set to `nil`.

 From comment:3:ticket:34049.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34050>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online