[tor-bugs] #33952 [Applications/Tor Browser]: Document the process to update ssh keys and add/remove users from build-sunet-a.torproject.net

[Tor Bug Tracker & Wiki]

#33952: Document the process to update ssh keys and add/remove users from build-
sunet-a.torproject.net
--------------------------------------+------------------------------
 Reporter:  boklm                     |          Owner:  tbb-team
     Type:  task                      |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202004R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by boklm):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:3 gk]:
 > Replying to [comment:1 boklm]:
 > > There is a patch for review in branch `bug_33952`:
 > > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33952&id=409a0e2a9a27a79ae6b74f8b1816df2fe6bc8d8e
 > >
 > > I did not check that the instructions for removing users actually
 work.
 >
 > Looks mostly good. Maybe add a sentence about the user dir on the build
 machine? That's still there after removing the user with your
 instructions, right?

 This should remove the user's home directory too (at least this is what
 the line `remove: yes` in `roles/tbb-team/tasks/main.yml` is supposed to
 do). I clarified that in:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33952&id=9ebd1fde48f851ec431dd7cbf03628d1e319d07f

 >
 > Some nits:
 >
 > s/used to setup/used to set up/
 > s/To update ssh key/To update the ssh key/

 I fixed that in:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33952&id=38c7c5be3e1d4826c16eeb9bf3aef2212a6b0be3

 I also added a sentence about testing the changes without applying them:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33952&id=07f3f85c6a4b64e8be7fc2b2173ddc60768b4bdb

 The squashed commit is now in branch `bug_33952_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33952_v2&id=513da8008078851501da2e4e9c2d91c4fbfdb5bf

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33952#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online