[tor-bugs] #33407 [Core Tor/Tor]: Make chutney bridge authorities publish bridges in their networkstatus-bridges

[Tor Bug Tracker & Wiki]

#33407: Make chutney bridge authorities publish bridges in their networkstatus-
bridges
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, tor-bridge, chutney,  |  Actual Points:
  outreachy-ipv6                                 |
Parent ID:  #33050                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------

Old description:

> This chutney fix is blocked by a tor bridge bootstrap / descriptor upload
> race condition, see #33582.
>
> (Chutney may need to check for this tor bug fix. One way to do that is to
> modify the tor version EXTRA_INFO so it is sortable, see #33408.)
>
> Chutney bridge authorities don't have any bridges in their networkstatus-
> bridges. That's a problem, because we want to check networkstatus-bridges
> for the reachability checks in #33232.
>
> There are two different ways to fix this issue:
> 1. Implement the robust ORPort reachability self-tests in #33222. Bridges
> bootstrap, self-test reachability, and then publish their descriptors.
>
> 2. Make bridge descriptor upload wait until the bridge has bootstrapped
> in #33582. Bridges bootstrap, then publish their descriptors.
>
> Once bridges upload their descriptors, we can make chutney check the
> bridge authority's networkstatus-bridges for bridge nicknames (this
> ticket).
>
> We can only do the networkstatus-bridges check on tor versions with the
> #33222 or #33582 fixes. If we want to do these tests before an
> 0.4.4-alpha release, we can:
> * implement ordered version EXTRA_INFO in #33408,
> * check for a log message that we add to tor during the fix, or
> * set an environmental variable.
>
> Whatever we do, we should also check for the next 0.4.4-alpha release, so
> we don't depend on these implementation details.
>
> We don't have to do these fixes, because it should be enough to test
> relay reachability. But we would risk breaking bridge reachability tests,
> and not knowing about it until after a release.

New description:

 Instead of this fix, we can make chutney check tor's logs for reachability
 self-test successes. See #34037.

 This chutney fix also needs fixes to a tor bridge descriptor upload race
 condition, see #33582.

 (Chutney may need to check for this tor bug fix. One way to do that is to
 modify the tor version EXTRA_INFO so it is sortable, see #33408.)

 Chutney bridge authorities don't have any bridges in their networkstatus-
 bridges. That's a problem, because we want to check networkstatus-bridges
 for the reachability checks in #33232.

 There are two different ways to fix this issue:
 1. Implement the robust ORPort reachability self-tests in #33222. Bridges
 bootstrap, self-test reachability, and then publish their descriptors.

 2. Make bridge descriptor upload wait until the bridge has bootstrapped in
 #33582. Bridges bootstrap, then publish their descriptors.

 Once bridges upload their descriptors, we can make chutney check the
 bridge authority's networkstatus-bridges for bridge nicknames (this
 ticket).

 We can only do the networkstatus-bridges check on tor versions with the
 #33222 or #33582 fixes. If we want to do these tests before an 0.4.4-alpha
 release, we can:
 * implement ordered version EXTRA_INFO in #33408,
 * check for a log message that we add to tor during the fix, or
 * set an environmental variable.

 Whatever we do, we should also check for the next 0.4.4-alpha release, so
 we don't depend on these implementation details.

 We don't have to do these fixes, because it should be enough to test relay
 reachability. But we would risk breaking bridge reachability tests, and
 not knowing about it until after a release.

--

Comment (by teor):

 Instead of this fix, we can make chutney check tor's logs for reachability
 self-test successes. See #34037.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33407#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online