[tor-bugs] #33987 [Applications/Tor Browser]: Make var/build_id_txt work in non-build steps

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 24 17:08:28 UTC 2020


#33987: Make var/build_id_txt work in non-build steps
--------------------------------------+------------------------------
 Reporter:  boklm                     |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202004R     |  Actual Points:
Parent ID:  #33973                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by boklm):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  new => needs_review


Comment:

 I tested this with and without the patch, with rbm patched for #33990:
 {{{
 for target in torbrowser-android-armv7 torbrowser-android-x86 torbrowser-
 android-x86_64 torbrowser-android-aarch64 torbrowser-linux-i686
 torbrowser-linux-x86_64 torbrowser-windows-x86_64 torbrowser-windows-i686
 torbrowser-osx-x86_64
 do
     ~/rbm/rbm showconf tor-browser filename --target alpha --target
 "$target" >> filenames1.txt;
 done
 }}}

 And the filenames were the same in both cases. So I think the patch is
 good for review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33987#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list