[tor-bugs] #33957 [Core Tor/Chutney]: Unexpected keyword argument 'bufsize' in subprocess.check_output()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 23 17:58:38 UTC 2020
#33957: Unexpected keyword argument 'bufsize' in subprocess.check_output()
------------------------------+-------------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Core Tor/Chutney | Version:
Severity: Normal | Resolution: fixed
Keywords: prop311, prop312 | Actual Points:
Parent ID: | Points:
Reviewer: nickm | Sponsor: Sponsor55-can
------------------------------+-------------------------------
Changes (by nickm):
* status: needs_review => closed
* resolution: => fixed
Comment:
I agree with removing bufsize in this case. The `check_output` function
doesn't return until the subprocess is done, and it returns the whole
string from the process's output -- it doesn't make sense to disable
buffering with `check_output`.
Merging this to master.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33957#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list