[tor-bugs] #33977 [Core Tor/Tor]: Lift circuit_build_times_disabled out of circuit_expire_building loop

[Tor Bug Tracker & Wiki]

#33977: Lift circuit_build_times_disabled out of circuit_expire_building loop
------------------------------+------------------------------
 Reporter:  Hello71           |          Owner:  (none)
     Type:  enhancement       |         Status:  new
 Priority:  Medium            |      Component:  Core Tor/Tor
  Version:  Tor: unspecified  |       Severity:  Normal
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
 profiling shows this function occupies about 2% of CPU time on an active
 relay because networkstatus_get_param uses string comparisons. I think
 this change is safe because new consensuses are not fetched in this
 function, nor can config options be modified while in this loop, nor is
 the state file written to. Moreover, the worst case scenario is that a
 warning is accidentally shown or not shown.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33977>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online