[tor-bugs] #7193 [Core Tor/Tor]: Tor's sybil protection doesn't consider IPv6
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Apr 22 11:33:06 UTC 2020
#7193: Tor's sybil protection doesn't consider IPv6
-------------------------------------------------+-------------------------
Reporter: asn | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, intro, tor-dirauth, security, | Actual Points:
sybil, network-health, outreachy-ipv6, |
network-team-roadmap-2020Q1 |
Parent ID: #24403 | Points: 1
Reviewer: nickm | Sponsor:
| Sponsor55-can
-------------------------------------------------+-------------------------
Comment (by nickm):
Replying to [comment:38 maurice_pibouin]:
> Thank you for the review !
>
> * I'm not sure what you mean by new patch : a different PR, branch,
issue, or just new commits ?
New commits would be fine.
> * I didn't do a PR because I thought it was reserved to "finished"
patches (ie that include tests), I will use a PR next time
It's good to have a PR even if it's not ready. That lets you get CI
results, and lets us comment directly on the code.
> * Comment removal was a mistake
> * I didn't see anything in `CodingStandards.md` about the if-else
newline, is it just common good practice ?
It's what we do in the rest of the code, except in a few places where we
didn't catch it during initial code review.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7193#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list