[tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

[Tor Bug Tracker & Wiki]

#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--------------------------------------+--------------------------------
 Reporter:  acat                      |          Owner:  acat
     Type:  task                      |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202004R     |  Actual Points:  14
Parent ID:  #33661                    |         Points:
 Reviewer:  sysrqb, pospeselr         |        Sponsor:  Sponsor58-must
--------------------------------------+--------------------------------

Comment (by acat):

 Working on #31918, I looked a bit more at some patches (especially Android
 ones), and saw that several could (I think) be dropped. So to make #31918
 easier, I made a new branch for this ticket with changes that probably
 belong here and not in #31918.

 The new branch is https://github.com/acatarineu/tor-
 browser/commits/33533+4. I dropped the temp. fixups at the end of the
 previous branch, as those should be handled in child tickets and were only
 added to make a tor-browser-build easier.

 The rest of changes from 33533+3 to 33533+4 are:

 {{{
 Bug 28051 - Integrate Orbot and add dependencies
   drop, assuming we do not need anymore.

 Bug 25906 - Imply false both Adjust and Leanplum configure options
   drop, don't see this beeing used anymore.

 Bug 26528 - Don't allow Fennec to use UpdateService when installed through
 the app store
   drop, it does not even apply anymore to mozilla-beta, and the
   function was not really used anymore when this was rebased.

 Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
   Moved `000-tor-browser*` changes from
   `Bug 25741 - TBA: Add mozconfig for Android and pertinent branding
 files.`
   to this one, since I think it belongs here.

   Removed change in browser/app/profile/000-tor-browser.js,
   `forward_oma_android_download_manager` is already false by
   default, and I do not see it being used anymore (this avoids
   a conflict in #31918 when rebasing the branch with autosquash).

   Also, moved `@BINPATH@/@PREF_DIR@/000-tor-browser-android.js`
   line in mobile/android/installer/package-manifest.in to make
   sure it's used in geckoview.

 Bug 25741 - TBA: Add mozconfig for Android and pertinent branding files.
   drop, part of it went to the pref overrides above, and the
   rest (mobile branding) I think it's not needed anymore.

 Bug 26045: Add new MAR signing keys
   drop, assuming that it's enough to have `Bug 32658: Create a new MAR
 signing key.`

 Bug 22548: Firefox downgrades VP9 videos to VP8.
   Removed default pref change in StaticPrefList.yaml, which I
   don't think is needed. I think this makes it better for this
   to be squashed with pref overrides.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33533#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online