[tor-bugs] #33918 [Core Tor/Tor]: Stop truncating IPv6 addresses in channel logs

[Tor Bug Tracker & Wiki]

#33918: Stop truncating IPv6 addresses in channel logs
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.4.4-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, prop312,              |  Actual Points:  0.1
  043-backport                                   |
Parent ID:  #33050                               |         Points:  0.1
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  ipv6, prop311, prop312 => ipv6, prop311, prop312, 043-backport
 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:2 nickm]:
 > LGTM.  We could backport this if you think it's worthwhile.

 I think it could go back to 0.4.3 now.

 I don't see much reason to backport further. Truncations should be rare in
 practice, and the function isn't actually used much.

 > Also do you think it's worth defining a new TOR_ADDRPORT_BUF_LEN?

 In new code, yes. Let's do that in master in a separate ticket.

 > Please feel free to merge and/or put in merge_ready when you're
 satisfied with it.

 I'll cherry-pick to 0.4.3 then merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33918#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online