[tor-bugs] #33919 [Core Tor/Tor]: Write unit tests for channel_matches_target_addr_for_extend()

[Tor Bug Tracker & Wiki]

#33919: Write unit tests for channel_matches_target_addr_for_extend()
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  task     |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  prop311, ipv6, technical-debt,
     Severity:  Normal   |  outreachy-ipv6, tests
Actual Points:           |  Parent ID:  #33048
       Points:  0.5      |   Reviewer:
      Sponsor:           |
  Sponsor55-can          |
-------------------------+-------------------------------------------------
 In #33817, we modify channel_matches_target_addr_for_extend() to take an
 IPv4 and an IPv6 address.

 We also modify channel_get_for_extend() to take an IPv4 and an IPv6
 address. It has existing tests, but they ignore IP addresses. (And mock
 the matches_target() method, which is called by
 channel_matches_target_addr_for_extend().)

 It would be useful to have tests that check that a channel matches, if its
 IP address matches the IPv4 or IPv6 address. But it's not urgent. (And the
 actual changes to the function are pretty trivial.)

 The setup for these tasks is a bit tricky, we need to set up a
 channel_tls_t and an associated connection_t with a real_addr. (Note that
 #33898 may change the name of real_addr.)

 This task is not urgent or important. Anyone can do this task.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33919>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online