[tor-bugs] #33850 [Core Tor/Tor]: log rotation for /var/log/tor/debug.log did not close handle to old file after compression

[Tor Bug Tracker & Wiki]

#33850: log rotation for /var/log/tor/debug.log did not close handle to old file
after compression
--------------------------+------------------------
 Reporter:  MaKoTor       |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by MaKoTor):

 Confirmed the behavior on two Ubuntu 16.04 and 18.04 as well, so far
 affected afaik:

 0.4.2.7-1~xenial+1
 0.4.2.7-1~bionic+1
 0.4.2.7-1~d8.jessie+1

 The /etc/logrotate.d/tor in all these packages does not explicitly HUP,
 instead it:

 {{{
  postrotate
                 if invoke-rc.d tor status > /dev/null; then
                         invoke-rc.d tor reload > /dev/null
                 fi
 }}}

 Running "sudo service tor reload" manually does reload the config and
 produces, among others, this log line:

 {{{
 Apr 14 08:49:19.000 [notice] Received reload signal (hup). Reloading
 config and resetting internal state.
 }}}

 And I find this line in all the compressed log files as well.

 Thanks, ama, for the hup pointer - what is the next low-hanging fruit to
 check?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33850#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online