[tor-bugs] #33899 [Core Tor/Tor]: Allow IPv6 addresses to be canonical

[Tor Bug Tracker & Wiki]

#33899: Allow IPv6 addresses to be canonical
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, network-team-         |  Actual Points:  0.3
  roadmap-2020Q2                                 |
Parent ID:  #33220                               |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.3


Comment:

 See my PR:
 * master: https://github.com/torproject/tor/pull/1862

 I don't think we should backport this change.

 I don't think we should write unit tests for the logging here, because
 that will change in #33898. But I'm happy to write unit tests for the
 set_canonical() part of this fix.

 I'll let CI run first, and get an initial review. (The review isn't
 urgent, it's a bit of a side issue to #33817.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33899#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online