[tor-bugs] #33545 [Core Tor/Tor]: assertion failure when "all zero" client auth key provided

[Tor Bug Tracker & Wiki]

#33545: assertion failure when "all zero" client auth key provided
-------------------------------------+-------------------------------------
 Reporter:  mcs                      |          Owner:  asn
     Type:  defect                   |         Status:  needs_review
 Priority:  High                     |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor             |        Version:  Tor: 0.4.4.0-alpha-
                                     |  dev
 Severity:  Normal                   |     Resolution:
 Keywords:  043-must security        |  Actual Points:  0.2
  extra-review                       |
Parent ID:                           |         Points:
 Reviewer:  dgoulet, nickm           |        Sponsor:
-------------------------------------+-------------------------------------

Comment (by nickm):

 I don't think there is an actual difference before and after the fixup.
 Try this demo:
 {{{
 #include <stdio.h>

 int
 main(int c, char**v)
 {
   struct foo { char array[10]; };

   struct foo x;

   printf("%p\n", x.array);
   printf("%p\n", &x.array);
   return 0;
 }
 }}}

 Note that both pointers are the same.

 I'm happy to merge this now, or wait for dgoulet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33545#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online