[tor-bugs] #33892 [Applications/Tor Browser]: Add brandProductName to torbutton brand localization files

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Apr 13 12:20:15 UTC 2020


#33892: Add brandProductName to torbutton brand localization files
------------------------------------------+--------------------------------
     Reporter:  acat                      |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam202004
Actual Points:                            |  Parent ID:  #33533
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 `brandProductName` was already present in ESR68, but we did not update
 torbutton `brand.dtd` or `brand.properties` files. For 68, this does not
 break the browser, since `brandProductName` is not used as an xml entity
 (DTD), and the `.properties` usage is in a path we probably do not
 [https://searchfox.org/mozilla-
 esr68/rev/c6e395f8a8512bec0dea4d3526831a3dbbae90e4/toolkit/profile/content/profileSelection.js#86
 hit].

 Currently, this is string is used in several additional places, and
 starting Firefox 70 it's used as a [https://searchfox.org/mozilla-
 central/rev/b7f3977978922d44c7d92ae01c0d4cc2baca7bc2/browser/locales/en-
 US/chrome/browser/browser.dtd#68 DTD entity], which prevents the browser
 from starting if it's not defined.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33892>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list