[tor-bugs] #33873 [Core Tor/Tor]: client: Send back SOCKS extended error F6 in case of bad hostname

[Tor Bug Tracker & Wiki]

#33873: client: Send back SOCKS extended error F6 in case of bad hostname
------------------------------+---------------------------------------
     Reporter:  dgoulet       |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs, tor-client, socks
Actual Points:                |  Parent ID:
       Points:  0.1           |   Reviewer:  asn
      Sponsor:                |
------------------------------+---------------------------------------
 With the new awesome TB 9.5a11, the SocksPort `ExtendedErrors` are being
 handled.

 Passing an invalid v3 address that is of the right length in bytes, will
 send back the `F6` error but not for an invalid address like:
 `asijdijasdoijqwoieqw.onion`.

 Problem is that we only send back the `F6` code if the address was
 identified, by length, as a v3. We should handle the `BAD_HOSTNAME` error
 code from `parse_extended_hostname()` and thus send back that extended
 error.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33873>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online