[tor-bugs] #33087 [Core Tor/Tor]: closing stdio fds on exit can interfere with LeakSanitizer, etc

[Tor Bug Tracker & Wiki]

#33087: closing stdio fds on exit can interfere with LeakSanitizer, etc
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.6
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-log, 043-should, consider-       |  Actual Points:  0.5
  backport-after-0433, 041-backport,             |
  042-backport                                   |
Parent ID:                                       |         Points:  0.2
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.2.x-final


Comment:

 I've merged this to 0.4.3, and added a small tweak as
 c4da0a5094e21241db8ce0d8b12c2e4272fa49ef. (The tweak is to add fsync to
 the list of syscalls that our sandbox permits. Let's not duplicate the
 drama we had with the dup syscall.)

 Marking for backport. No need to backport the tweak, since the version of
 this branch targeting 0.4.1 doesn't use fsync.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33087#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online