[tor-bugs] #33633 [Core Tor/Tor]: Move extend and reachability code to the relay module

[Tor Bug Tracker & Wiki]

#33633: Move extend and reachability code to the relay module
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, technical-debt,       |  Actual Points:  1.0
  network-team-roadmap-2020Q1                    |
Parent ID:  #33220                               |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I wrote comprehensive unit tests for the circuit_extend() function and
 helpers. During the rewrite, I re-ordered and fixed many of the existing
 commits.

 I deferred the rest of test_onionskin_answer() to #33860 (part of #33221).

 See my PR:
 * master: https://github.com/torproject/tor/pull/1801

 I want to work off this branch for #33817, which is my next task. If you'd
 like me to make major changes to this code, please let me know as soon as
 possible. I'd like to avoid conflicts with #33817, #33818, and the rest of
 #33220.

 Otherwise, I don't mind when the review or merge happens. I'm happy to
 work off un-merged branches.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33633#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online