[tor-bugs] #32542 [Core Tor/Tor]: hs-v3: Add the 2 missing SOCKS extended errors from prop304

[Tor Bug Tracker & Wiki]

#32542: hs-v3: Add the 2 missing SOCKS extended errors from prop304
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, 043-can, network-team-       |  Actual Points:  0.4
  roadmap-2020Q1                                 |
Parent ID:  #30025                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 I was able to test the `F2` code and confirm we get it if all IPs NACK us.
 The `F3` and `F7` are timeout and apart from unit testing, I'm unable to
 test with chutney without some heavy tor modification.

 At least that code base is unit tested so I'm confident for no crash.
 We'll have to see with 044 stabilization any bugs for those code.

 Branch: `ticket32542_044_01`
 PR: https://github.com/torproject/tor/pull/1857

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32542#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online