[tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, prop312, ipv6,         |  Actual Points:  0.3
  outreachy-ipv6, network-team-roadmap-2020Q1    |
Parent ID:  #33049                               |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Code looks good. The only problem I have is with the git history.

 For instance, I do not know what the fixup commits are against which
 commits? :S

 May I suggest here to just rebase the branch against master, squash most
 of the commits into 2 commits basically, one for the IPv6 functionality
 and second one for the added tests?

 If you need help with this, let me know, I can propose a branch and you
 can tell me if it works for you.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online