[tor-bugs] #33833 [Applications/Tor Browser]: Upgrade Rust To Use Android NDK 21

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Apr 6 17:16:58 UTC 2020


#33833: Upgrade Rust To Use Android NDK 21
--------------------------------------+------------------------------
 Reporter:  sisbell                   |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile, Android       |  Actual Points:  .5
Parent ID:  #33184                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by sisbell):

 * status:  new => needs_review
 * actualpoints:   => .5


Comment:

 gcc is no longer supported in the Android NDK so I moved this to use
 clang.

 Rust was no longer able to find the ar command. This occurs since the
 clang executable has the android API level in the file name.

 {{{
 i686-linux-android29-clang
 }}}
 Rust tries to use the name of the clang command, with API, to infer the
 target as

 {{{
 i686-linux-android29-ar
 }}}

 However, ar is

 {{{
 i686-linux-android-ar
 }}}

 I add the correct ar in options to solve this issue.

 There is an oddity for arm, which doesn't occur in other platform
 variants. As ar is


 {{{
 arm-linux-androideabi-ar
 }}}

 while clang is

 {{{
 armv7a-linux-androideabi29-clang
 }}}


 so arm ar doesn't contain any portion of the correct host. So the options
 are a little different here.

 https://github.com/sisbell/tor-browser-build/commits/bug-33833

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33833#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list