[tor-bugs] #33782 [Core Tor/Tor]: Increases TEST_CONN_FD_INIT to make tests working on GitHub Actions

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 2 22:31:11 UTC 2020


#33782: Increases TEST_CONN_FD_INIT to make tests working on GitHub Actions
--------------------------+------------------------------------
 Reporter:  ultimaweapon  |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:  0.4.2.6
 Severity:  Normal        |     Resolution:
 Keywords:  tor-test      |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * version:  Tor: unspecified => 0.4.2.6


Comment:

 I would use 1000 as the minimum fake FD.
 Or something ridiculously large, like 30,000.

 Most systems default to 512 or 1024 file descriptors as a minimum.
 So most processes tor is embedded in shouldn't ever use that many.

 Also, do we want to backport this patch?
 It seems like a good candidate for 0.4.3 at least.

 It also seems like we might run into this issue more often, because more
 people are embedding tor. (It's unusual to embed the unit tests, but not
 entirely unreasonable. For example, we like to know if the unit tests pass
 on a real iOS device.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33782#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list