[tor-bugs] #33800 [Circumvention/Snowflake]: Remove uniuri dependency
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 2 21:15:34 UTC 2020
#33800: Remove uniuri dependency
-------------------------------------+------------------------------
Reporter: dcf | Owner: dcf
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+------------------------------
Changes (by dcf):
* status: assigned => needs_review
Comment:
This patch replaces `uniuri.New()` with a manual call to
`crypto/rand.Read`. Panicking on read error is the same thing uniuri does.
8 hex-encoded bytes are the same length as `uniuri.New()`, but only 64
bits compared to `uniuri.New()`'s ~95 bits (16 characters of base-62).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33800#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list