[tor-bugs] #33789 [Core Tor/Tor]: Before making changes, move router pick address functions to their own C file

[Tor Bug Tracker & Wiki]

#33789: Before making changes, move router pick address functions to their own C
file
--------------------------------+--------------------------------
     Reporter:  teor            |      Owner:  teor
         Type:  task            |     Status:  assigned
     Priority:  Medium          |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor    |    Version:
     Severity:  Normal          |   Keywords:  ipv6, prop312
Actual Points:                  |  Parent ID:  #33049
       Points:  1               |   Reviewer:
      Sponsor:  Sponsor55-must  |
--------------------------------+--------------------------------
 As part of Sponsor 55, let's move these relay functions to their own C
 files:

 In src/feature/relay/resolve_addr_relay.c
 * router_pick_published_address()

 In src/app/config/resolve_addr.c
 * resolve_my_address()
 * get_last_resolved_addr()
 * reset_last_resolved_addr()
 * last_resolved_addr
 * is_local_addr()
 * is_local_addr_impl()

 These are relay-level now, but I think they should become client-level:
 * router_new_address_suggestion()
 * router_guess_address_from_dir_headers()

 We should also move any related functions.

 And write unit tests :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33789>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online