[tor-bugs] #33768 [Core Tor/Tor]: Make tor_inet_pton() handle bad addresses consistently on Windows

[Tor Bug Tracker & Wiki]

#33768: Make tor_inet_pton() handle bad addresses consistently on Windows
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  044-should, 035-backport,            |  Actual Points:
  041-backport, 042-backport, 043-backport,      |
  outreachy-ipv6, ipv6, windows                  |
Parent ID:  #33049                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     044-should, security-low, 035-backport, 041-backport, 042-backport,
     043-backport, outreachy-ipv6, ipv6, windows
     =>
     044-should, 035-backport, 041-backport, 042-backport, 043-backport,
     outreachy-ipv6, ipv6, windows


Comment:

 I have confirmed that this is not currently a security issue: all calls to
 tor_inet_pton() check the return value.

 All the other functions in that file can't return incomplete results,
 because they don't build the result incrementally in the returned
 variable(s).

 I've noticed some places where return values aren't checked, I'll make
 child tickets.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33768#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online