[tor-bugs] #28005 [Applications/Tor Browser]: Officially support onions in HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#28005: Officially support onions in HTTPS-Everywhere
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, https-everywhere, network-   |  Actual Points:  18.3
  team-roadmap-november, network-team-roadmap-   |
  2020Q1, ux-team, TorBrowserTeam202004R         |
Parent ID:  #30029                               |         Points:  20
 Reviewer:  mcs, sysrqb, antonela                |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 (Continuing)

 Duplicating `allowOnionUrlbarRewrites` in both the DocShell and SHEntry is
 concerning, but I don't see an alternative right now.

 `browser/components/onionservices/OnionAliasStore.jsm`
 {{{
 +    // If the timestamp is 0, that means the update channel was not yet
 updated, so
 +    // we schedule a check soon.
 }}}

 I believe this applies for both `ts` === `0` and `null`, correct? Can you
 mention `null` in the comment, as well?

 {{{
 +    // Setup .tor.onion rule loading.
 +    this._loadHttpObserver();
 +    try {
 +      await this.httpsEverywhereControl.getTorOnionRules();
 +      this._canLoadRules = true;
 }}}

 Ah. Can you add a comment that the httpObserve is removed in
 `_loadRules()`? That wasn't immediately obvious.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28005#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online