[tor-bugs] #33781 [Core Tor/Tor]: DocTor chokes on malformed dirreq-stats-end line

[Tor Bug Tracker & Wiki]

#33781: DocTor chokes on malformed dirreq-stats-end line
-------------------------------------------+-------------------------------
 Reporter:  gk                             |          Owner:  (none)
     Type:  defect                         |         Status:  new
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  044-should, dir-spec, torspec  |  Actual Points:
Parent ID:                                 |         Points:  1
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by teor):

 * cc: nickm (added)
 * keywords:   => 044-should, dir-spec, torspec
 * points:   => 1
 * milestone:   => Tor: 0.4.4.x-final


Comment:

 I suspected that the relay might be on Windows, but it's on Linux right
 now:
 https://metrics.torproject.org/rs.html#details/0C0388BC552D7AC903F49390A40244FD3FFF44A2

 I wonder if it was previously on Windows?

 One relay in the operator's family is on Windows:
 https://metrics.torproject.org/rs.html#details/B5A91AAD55037CB751AB88D910D81AA6367A1A61

 And one other is on Linux:
 https://metrics.torproject.org/rs.html#details/CE5ED345398CC02D573347C2F238F80B18E680EE

 Here are a few different ways to solve this issue:
 * tor refuses to upload any docs that contain CR
 * authorities (and bridge clients, and HSDirs) reject docs that contain CR
 ?
 * we amend dir-spec to allow CRLF or LF at the end of lines ?

 I wonder what nickm thinks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33781#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online