[tor-bugs] #33779 [Core Tor/Tor]: Fix incorrect PublishHidServDescriptors value in logs

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 1 09:27:32 UTC 2020


#33779: Fix incorrect PublishHidServDescriptors value in logs
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  044-should, tor-hs
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 This code should say:
 "PublishHidServDescriptors is set to 0."

 But it says:
 {{{
   /* Let's avoid doing that if tor is configured to not publish. */
   if (!get_options()->PublishHidServDescriptors) {
     log_info(LD_REND, "Service %s not publishing descriptor. "
                       "PublishHidServDescriptors is set to 1.",
              safe_str_client(service->onion_address));
     goto end;
   }
 }}}

 I'll leave it to dgoulet and asn to fix, and decide how far it needs to be
 backported.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33779>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list