[tor-bugs] #5915 [Core Tor/Tor]: Write patch to make socks handshakes succeed instantly

[Tor Bug Tracker & Wiki]

#5915: Write patch to make socks handshakes succeed instantly
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  needs-proposal, tor-client, intro,   |  Actual Points:
  performance, application, experiment, tbb-     |
  wants?, performance?, ux,                      |
  042-deferred-20190918                          |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by tom):

 While I'm very appreciative of this patch; as detailed in
 https://lists.torproject.org/pipermail/tor-dev/2019-September/014045.html
 I do not think this is the best approach.

 We do not need to use the display_error_message function (especially since
 it won't work for HTTPS) and we do need to avoid optimistic data for onion
 sites. Additionally, we should put this behind a SocksPort flag.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5915#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online