[tor-bugs] #31192 [Applications/Tor Browser]: TBA - Support x86_64 target

[Tor Bug Tracker & Wiki]

#31192: TBA - Support x86_64 target
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, ff68-esr,       |  Actual Points:
  GeorgKoppen201907, TorBrowserTeam201909        |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:28 sysrqb]:
 > Replying to [comment:25 cypherpunks]:
 > > Looks mostly good, but don't you want to get a review from the tbb-
 team?
 >
 > Good point.
 >
 > > {{{
 > > +ac_add_options --with-android-version=21
 > > }}}
 > > is not needed.
 >
 > True, but we have this in the other mozconfigs, and I'd like consistency
 between them. We should clean them up after this esr transition is
 complete.
 >
 > > {{{
 > > +export MOZ_LTO=1
 > > }}}
 > > is needed.
 >
 > Hrm. Is it? I found https://bugzilla.mozilla.org/show_bug.cgi?id=1480006
 which suggests it is a good idea and provides significant improvements,
 but it isn't needed. I'd prefer letting a change like this bake in nightly
 and alpha for a few releases after 9.0 becomes stable, unless this really
 is needed.

 I agree with that. Enabling LTO is a big change which we should test
 thoroughly. That's part of the plan to get closer to ship what Mozilla is
 actually shipping. I am not exactly sure whether Mozilla is actually
 shipping release builds for Android with LTO enabled, I only found nightly
 and beta mozconfigs saying so after a cursory search, but e.g. macOS
 release builds have this enabled. I created a parent ticket (#31860) where
 we can use child tickets for the platforms we want to enable LTO for.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31192#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online