[tor-bugs] #31736 [Core Tor/Tor]: Stop using mutex_destroy(), when multiple threads can still access the mutex
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Sep 26 02:39:50 UTC 2019
#31736: Stop using mutex_destroy(), when multiple threads can still access the
mutex
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.5.1-alpha
Severity: Normal | Resolution:
Keywords: consider-backport-after-042-stable, | Actual Points: 0.5
consider-backport-if-needed, diagnostics, |
042-should, 035-backport-maybe, 040-backport- |
maybe, 041-backport-maybe, regression, |
BugSmashFund, asn-merge |
Parent ID: #31614 | Points: 0.2
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => needs_review
* actualpoints: 0.4 => 0.5
Comment:
I found another fix that might be much safer: using a sentinel variable to
only initialise global mutexes once, regardless of the number of times
that tor is re-initialised. (We already do this with the logs, so that we
can keep seeing logs during shutdown.)
I updated the usage comments in this branch, and added a note to #31735.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31736#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list