[tor-bugs] #31812 [Core Tor/Tor]: http URL's in docs/comments should be https

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 25 21:52:15 UTC 2019


#31812: http URL's in docs/comments should be https
--------------------------+------------------------------------
 Reporter:  JeremyRand    |          Owner:  (none)
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  042-can docs  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  catalyst      |        Sponsor:
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:1 JeremyRand]:
 > Patch at https://notabug.org/JeremyRand/tor/src/https-urls (Git commit
 hash `90feaa278b6b58ea67a1ab4e5fb7ea417741dc75`).
 Thanks for the patch! It mostly looks good. I have a few minor comments.

 Did you verify that each HTTPS URL that you produced actually works?

 Also, I would prefer to leave "upstream" text unchanged. This includes the
 comments in Doxyfile.in (which is auto-generated boilerplate from Doxygen)
 and license text in LICENSE. (Some licenses arguably require verbatim
 reproduction of the license text, and it's unclear to me whether changing
 `http://` to `https://` would be allowed. We could check whether the
 upstream projects have updated the URLs in their license text, I guess.)

 What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31812#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list