[tor-bugs] #28196 [Applications/Tor Browser]: about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4

[Tor Bug Tracker & Wiki]

#28196: about:preferences#general is not properly translated anymore starting with
Tor Browser 8.5a4
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-regression,                      |  Actual Points:
  TorBrowserTeam201909R11                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):

 * keywords:  tbb-regression, TorBrowserTeam201811 => tbb-regression,
     TorBrowserTeam201909R11
 * status:  needs_information => needs_review


Comment:

 Patches for review in https://github.com/acatarineu/tor-
 browser/commit/28196 and
 https://github.com/acatarineu/torbutton/commit/28196.

 I realized that now we have `tor-browser-brand.ftl` in many more places
 than esr60, but this file is not shipped in mobile, which means that some
 UI is broken right now (not so critical though, some about: pages like
 `about:telemetry` or `about:rights`...). This patch should fix it, but
 there will be some inconsistencies with branding on mobile.

 In `mobile/android/branding/nightly/locales/en-US/brand.dtd` (similarly in
 the .properties version) we have:
 {{{
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

 <!ENTITY  brandShortName  "Nightly">
 <!ENTITY  brandFullName   "Tor Browser Nightly">
 <!-- LOCALIZATION NOTE (brandProductName):
    This brand name can be used in messages where the product name needs to
    remain unchanged across different versions (Nightly, Beta, etc.). -->
 <!ENTITY  brandProductName "Tor Browser">
 <!ENTITY  vendorShortName "The Tor Project">

 <!ENTITY  brandPocket     "">
 }}}

 while on the desktop one we always have "Tor Browser" as brand, for
 example in `browser/branding/nightly/locales/en-US/brand.dtd`:

 {{{
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

 <!ENTITY  brandShorterName      "Tor Browser">
 <!ENTITY  brandShortName        "Tor Browser">
 <!ENTITY  brandFullName         "Tor Browser">
 <!-- LOCALIZATION NOTE (brandProductName):
    This brand name can be used in messages where the product name needs to
    remain unchanged across different versions (Nightly, Beta, etc.). -->
 <!ENTITY  brandProductName      "Tor Browser">
 <!ENTITY  vendorShortName       "Tor Project">
 <!ENTITY  trademarkInfo.part1   "Firefox and the Firefox logos are
 trademarks of the Mozilla Foundation.">
 }}}

 So in mobile after this patch, in places where `tor-browser-brand.ftl` is
 used the brand will be `Tor Browser`, while in some other places in UI it
 might be `Nightly` or `Alpha`. Not sure if this is ok, or we should fix
 these branding inconsistencies between mobile and desktop.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28196#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online