[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Sep 19 14:43:08 UTC 2019


#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909                           |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:65 mcs]:
 > Replying to [comment:62 gk]:
 > > Any reason you omitted `!strstr(pathValue, pathToAppend)` in
 AppendToLibPath()? It might not be likely that this is an issue but having
 that check seems to be correct to me: there is no need to add the path if
 it's already there for whatever reason.
 >
 > You have forgotten about #18900 where we had to back out that part of
 Mozilla's code. With the ESR68 patches, we had to resurrect the entire
 `AppendToLibPath()` function (since Mozilla removed it completely) so we
 just omitted the problematic `strstr()` call in our implementation. We
 will add a mention of #18900 to the #13379 commit message.

 Well, indeed I had forgotten about that. However, why does this issue
 apply to macOS which is the only platform that part of the patch is
 concerned about? I mean we set `LD_LIBRARY_PATH` on Linux with the start
 script, so I see why we ran into #18900 but we don't touch the respective
 env variable on macOS, no?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:66>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list