[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909                           |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:62 gk]:
 > Here comes feedback for commit 21066b41d8844805876fa71e1ea562c5dfaac439:
 >
 > "This is used so that updater can find libmozsqlite3.so" s/updater/the
 updater/
 >
 > and not .so but .dylib in that comment as this is for macOS only.

 Thanks. We will produce a fixup for this. I think we will mention
 `libnss3.dylib` (as we do elsewhere in the patch).

 > "can located" -> can locate

 We will fix this too.

 > Any reason you omitted `!strstr(pathValue, pathToAppend)` in
 AppendToLibPath()? It might not be likely that this is an issue but having
 that check seems to be correct to me: there is no need to add the path if
 it's already there for whatever reason.

 You have forgotten about #18900 where we had to back out that part of
 Mozilla's code. With the ESR68 patches, we had to resurrect the entire
 `AppendToLibPath()` function (since Mozilla removed it completely) so we
 just omitted the problematic `strstr()` call in our implementation. We
 will add a mention of #18900 to the #13379 commit message.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:65>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online