[tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

[Tor Bug Tracker & Wiki]

#31652: hs-v3: Service circuit retry limit should not close a valid circuit
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  neel
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, tor-circuit, 042-should  |  Actual Points:
Parent ID:  #30200                           |         Points:  0.1
 Reviewer:  asn                              |        Sponsor:
                                             |  Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the fixups. I think that `if` block in `cleanup_intro_points()`
 has grown to an unruly complexity which is hard to understand what it's
 checking and why anymore. Can you please split into a separate function,
 split all the clauses into different `if` statements, and document them
 individually?

 Thanks! :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online