[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909                           |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 I took a look at commit 14df73ecfdd88db89f196cecfb934dab7e552969 (aka the
 rebased patch for #4234):

 Do we really want to disable staged updates for macOS? I feel if we don't
 have good reasons like we do for Windows and Linux we should a) not
 degrade the user experience here and b) not deviate from the update code
 path Mozilla is using (assuming that the alternative path is less tested).

 We need an updated logo for `aboutdebugging-firefox-release.svg` at least,
 right? Do we have a bug for that on file? (one can see the issue after
 flipping `devtools.aboutdebugging.new-enabled` and then opening
 `about:debugging`)

 Why do we suddenly need the `#ifdef XP_WIN` blocks around `closeHandle()`
 and friends? Just to make it abundantly clear that this is only used for
 Windows as is the ctypes inclusion? I wonder if we could that somehow
 upstream or make it clear upstream in a way  that we don't have to carry
 that part of the patch around every time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:59>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online