[tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck
--------------------------+----------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Low           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:  shellcheck    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by teor):

 Replying to [comment:3 nickm]:
 > Hm. I think this one is probably safe to remove: it has decorations
 indicating that it came from FreeBSD's CVS repository, which suggests to
 me that the FreeBSD people are probably maintaining their own version.

 +1

 > There are other scripts of this kind, however.  Maybe we should sent a
 message to the tor-packagers list, asking if anybody is currently using
 any of the init scripts from our repository?  If we find that some are in
 use, we can decide whether to keep them or to give other projects
 responsibility for them.

 I tried looking for these other scripts, and I could only find:
 * contrib/dist
   * rc.subr - script
   * tor.service.in - systemd service ini file

 Do you want me to ask tor-packagers about these two files?
 Or are there other files you are thinking of?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31576#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online