[tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

[Tor Bug Tracker & Wiki]

#31538: Windows bundles based on ESR 68 are not built reproducibly
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-     |  Actual Points:
  alpha, TorBrowserTeam201909R,                  |
  GeorgKoppen201909                              |
Parent ID:  #30322                               |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:23 tom]:
 > We seem to use a different technique for merging libraries than Martin:
 https://searchfox.org/mozilla-
 central/rev/d1e33e3e11f559952d7d80e722d26a6cf5dd80ac/taskcluster/scripts/misc
 /build-clang-8-mingw.sh#125

 No, that's a different piece. It merges `libc++` with `libunwind` which is
 actually okay. The problematic one, which you hit as well, is within the
 `libc++` build step where `libc++` and `libc++abi` are getting merged into
 `libc++`.

 > I don't know if ours is reproducible.  But Martin can probably upstream
 that clang change fairly easily. And I should - if not copy your approach
 - add a comment about it in our build.

 Upstream changed meanwhile, so the patch in question is only usable for
 clang 8-based toolchains. However, it seems the new changes still have the
 same issue potentially. I'll get back to Martin with that once this patch
 lands and we are good on our side.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31538#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online