[tor-bugs] #31637 [Core Tor/Tor]: Make sure we have test coverage for Option, +Option and /Option across defaults, torrc, command line

[Tor Bug Tracker & Wiki]

#31637: Make sure we have test coverage for Option, +Option and /Option across
defaults, torrc, command line
-----------------------------------------+---------------------------------
 Reporter:  teor                         |          Owner:  nickm
     Type:  enhancement                  |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  1.5
Parent ID:  #29211                       |         Points:
 Reviewer:  teor                         |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 This looks great - I'm really happy with this level of testing.

 It looks like we're testing a lot of non-default options.
 Did we try to test them all?

 Should we open a ticket for the tricky ones that we couldn't test?
 HardwareAccel
 ControlSocket
 ControlSocketWriteable
 Or are we just trying for a decent level of coverage right now?

 I'm happy to merge, if these tests also pass on 0.4.1.
 (Or if there is a good explanation for why they don't pass, like a new
 option.)
 That way, we can be sure that we aren't just testing the post-refactor
 behaviour.

 Feel free to flip to merge_ready once 0.4.1 passes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31637#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online