[tor-bugs] #31698 [Core Tor/Tor]: Reconsider HAVE_XXX_H usage in the Tor code

[Tor Bug Tracker & Wiki]

#31698: Reconsider HAVE_XXX_H usage in the Tor code
--------------------------+----------------------------------
 Reporter:  ahf           |          Owner:  (none)
     Type:  enhancement   |         Status:  new
 Priority:  Low           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by teor):

 Replying to [ticket:31698 ahf]:
 > But we don't expect to work on systems that do not have, for example,
 string.h available. We should not do these check in every .c and .h file,
 but instead just have our configure script fail if these headers are not
 available.

 How will we know which headers have substitutes, and which headers are
 actually required?

 For example, if a file is only using strlcat/strlcpy from string.h, and
 the platform doesn't have string.h, we should just use our implementations
 in compat_string.h. Just like we would for a platform that has string.h,
 but no strlcat/strlcpy.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31698#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online