[tor-bugs] #31742 [Core Tor/Tor]: Write a script or makefile target to install git hooks

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Sep 16 04:51:33 UTC 2019


#31742: Write a script or makefile target to install git hooks
--------------------------+------------------------
 Reporter:  rl1987        |          Owner:  (none)
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by teor):

 Here are some things we should be aware of:
 * it should be a script, which can optionally be called by a Makefile
 target
   * some people have (upstream merging) git directories with hooks, but no
 builds
 * We need a manual step: it's not safe to have executable scripts update
 themselves
 * The manual step should take its paths from:
   * environmental variables, to allow users to update all their git
 repositories at the same time
   * the current git working directory, according to the git command
     * if the user is in a worktree, the scripts should be copied into the
 working directory, not the worktree

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31742#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list