[tor-bugs] #31699 [Core Tor/Tor]: Remove unused configure.ac checks
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Sep 11 15:16:56 UTC 2019
#31699: Remove unused configure.ac checks
------------------------------+------------------------------
Reporter: nickm | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: unspecified
Component: Core Tor/Tor | Version: Tor: unspecified
Severity: Normal | Keywords: easy
Actual Points: | Parent ID: #31698
Points: | Reviewer:
Sponsor: |
------------------------------+------------------------------
Here is a little script to find macros in orconfig.h.in that are not
actually mentioned in our code:
{{{
#/bin/bash
for macroname in $(grep '#undef' orconfig.h.in | awk -e '{ print $2; }') ;
do
git grep -l "$macroname" src >/dev/null || echo "$macroname"
done
}}}
Some of these macros are used in system header files, but we can safely
remove the autoconf checks for the ones that are not. I think they are:
{{{
HAVE_EVENT2_BUFFEREVENT_SSL_H
HAVE_EVENT2_DNS_H
HAVE_EVENT2_EVENT_H
HAVE_EVP_SHA3_256
HAVE_GETPASS
HAVE_HTONLL
HAVE_LIBCAP
HAVE_MALLOC_MALLOC_H
HAVE_MALLOC_NP_H
HAVE_STRUCT_TCP_INFO_TCPI_SND_MSS
HAVE_STRUCT_TCP_INFO_TCPI_UNACKED
HAVE_SYS_SYSLIMITS_H
HAVE_U_CHAR
SRCDIR
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31699>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list