[tor-bugs] #31698 [Core Tor/Tor]: Reconsider HAVE_XXX_H usage in the Tor code

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 11 14:47:36 UTC 2019


#31698: Reconsider HAVE_XXX_H usage in the Tor code
------------------------------+------------------------------
     Reporter:  ahf           |      Owner:  (none)
         Type:  enhancement   |     Status:  new
     Priority:  Low           |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:  Tor: unspecified
     Severity:  Normal        |   Keywords:  easy
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 We currently sometimes have code like:

 {{{
 #ifdef HAVE_STRING_H
 #  include <string.h>
 #endif
 }}}

 But we don't expect to work on systems that do not have, for example,
 string.h available. We should not do these check in every .c and .h file,
 but instead just have our configure script fail if these headers are not
 available.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31698>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list