[tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of <sys/sysctl.h>

Mon Sep 9 15:57:59 UTC 2019

#31673: Deprecated use of <sys/sysctl.h>
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport 040-backport            |  Actual Points:
  041-backport                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * keywords:  035-backport 040-backport 041-backport 042-should easy =>
     035-backport 040-backport 041-backport
 * reviewer:   => nickm
 * status:  new => needs_review

Comment:

 There is two approach to this I believe. Either we keep
 `HAVE_SYS_SYSCTL_H` but add `!defined(__GLIBC__)` or we just remove this
 entirely and only include it _not_ for LInux/Win32 since most BSD flavors
 still uses it afaict.

 I went with the latter.

 029: https://github.com/torproject/tor/pull/1305
 035: https://github.com/torproject/tor/pull/1307

 035 PR merges forward successfully.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31673#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online