[tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of <sys/sysctl.h>

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of <sys/sysctl.h>
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  035-backport 040-backport
     Severity:  Normal   |  041-backport
Actual Points:           |  Parent ID:
       Points:  0.1      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 I've been getting warnings since couple days ago:

 {{{
 /usr/include/x86_64-linux-gnu/sys/sysctl.h:21:2: warning: #warning "The
 <sys/sysctl.h> header is deprecated and will be removed." [-Wcpp]
    21 | #warning "The <sys/sysctl.h> header is deprecated and will be
 removed."
 }}}

 It is annoying with `enable-gcc-warnings` since it errors.

 I've removed that include and tor builds fine so, as nickm suggested on
 IRC, right solution here is to not include on Linux/Win32 instead of
 `#ifdef HAVE_SYS_SYSCTL_H`.

 I would recommend a backport since if this becomes a problem to build tor
 in the future.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31673>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online