[tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

Mon Sep 9 05:05:15 UTC 2019

#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  BugSmash, diagnostics, consider-     |  Actual Points:  0.9
  backport-if-needed, consider-backport-         |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe         |
Parent ID:  #31571                               |         Points:  0.3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * keywords:
     BugSmash, diagnostics, 042-should, android, macos, 035-backport,
     040-backport, 041-backport
     =>
     BugSmash, diagnostics, consider-backport-if-needed, consider-backport-
     after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
     -backport-maybe
 * actualpoints:  0.7 => 0.9

Comment:

 I split #31614 and #31615 into their own PRs, the code is pretty
 independent. And the backport versions are different.

 I updated the PR with some fixups and a changes file:
 * fixups on master: https://github.com/torproject/tor/pull/1289

 I don't know if we need to do #31635.
 If we do, we should do it on master, after all these other branches merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online