[tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
--------------------------------------------+------------------------------
 Reporter:  backkem                         |          Owner:  cohosh
     Type:  enhancement                     |         Status:  accepted
 Priority:  Medium                          |      Milestone:
Component:  Circumvention/Snowflake         |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:                                  |         Points:  5
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor28-must
--------------------------------------------+------------------------------

Comment (by Sean-Der):

 @cohosh your changes have landed in master! Thank you so much for fixing
 that, and I really apologize for regressing that. I added a test in
 https://github.com/pion/webrtc/commit/9fa65c214765c65c118b03079b8f81ff365d4d6e
 to make sure we don't mess things up in the future.

 > !OnNegotiationNeeded is no longer supported, but putting the code from
 that callback into a go routine and calling it immediately after creation
 of the !PeerConnection seems to work just fine.

 This just doesn't exist yet because the work hasn't been put in (but it
 should!) I filed a ticket and will get that in.

 > By default, something called the "​trickle method" is set to false

 We do want to do this! It will just be an API breakage, when building the
 original version it was just easier not to do Trickle ICE. We use the
 SettingEngine to do non-portable behavior.

 > OnICECandidate returns a nil candidate when gathering is complete

 This is to match this behavior from W3C/ECMAScript implementation.

 {{{
  If the event's candidate property is null, ICE gathering has finished
 }}}

 If this is a sharp edge we should change/fix! Any ideas/how would you
 expect this to work?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28942#comment:62>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online