[tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded with
‘-fvar-tracking-assignments’
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  regression    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 Hm. My basic fix here will not solve #30968, but it might still be useful
 under the theory that we shouldn't acclimate people to ignoring warnings,
 even if the compiler calls those warnings "notes".

 Branch is ticket31354, which adopts a brute-force solution to solving the
 problem (reducing variables and splitting test functions).  I didn't do a
 changes file here, since AFAICT 0.4.1.x doesn't have this problem.

 https://github.com/torproject/tor/pull/1299 is the PR.  I'll put this in
 needs_review once it passes CI.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31354#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online