[tor-bugs] #31562 [Applications/Tor Browser]: The circuit display is not visible on error pages in Tor Browser based on ESR68

[Tor Bug Tracker & Wiki]

#31562: The circuit display is not visible on error pages in Tor Browser based on
ESR68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201909,      |  Actual Points:
  tbb-9.0-must-alpha                             |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  ff68-esr, TorBrowserTeam201909R, tbb-9.0-must-alpha =>
     ff68-esr, TorBrowserTeam201909, tbb-9.0-must-alpha
 * status:  needs_review => needs_revision


Comment:

 Are we sure browser.contentPrincipal.URI` can't be null? It seems the
 Firefox folks think otherwise (see: https://searchfox.org/mozilla-
 esr68/source/browser/base/content/browser.js#1092 and the comment at
 https://searchfox.org/mozilla-
 esr60/source/browser/base/content/browser.js#800). We should adapt our
 code I think.

 Are we sure `origin` was just syntactic sugar for `URI.spec`? We should be
 certain that we don't introduce a subtle bug here. I wonder what the new
 `siteOrigin` (https://bugzilla.mozilla.org/show_bug.cgi?id=1485177) would
 give us here. Maybe that's what we actually want?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31562#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online