[tor-bugs] #31632 [Core Tor/Tor]: hs-v3: Service doesn't re-upload descriptor on circuit failure

[Tor Bug Tracker & Wiki]

#31632: hs-v3: Service doesn't re-upload descriptor on circuit failure
--------------------------------+--------------------------------
     Reporter:  dgoulet         |      Owner:  (none)
         Type:  defect          |     Status:  new
     Priority:  Medium          |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor    |    Version:
     Severity:  Normal          |   Keywords:  tor-hs
Actual Points:                  |  Parent ID:  #30200
       Points:                  |   Reviewer:  asn
      Sponsor:  Sponsor27-must  |
--------------------------------+--------------------------------
 I'm observing, quite often actually, a service posting its descriptor to
 an HSDir but the circuit collapses due to remote reason `CHANNEL_CLOSED`.

 This is possible for many reasons where a link between two relays
 failed/disconnected/closed/...

 However, we do not retry the upload after that which means that we can end
 up with HSDir(s) without our descriptor even though we think they are
 there.

 Solution is unclear but it appears that we probably want to hook this case
 into `hs_circ_cleanup()` which is called from the mark for close function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31632>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online